[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 31 10:39:49 PDT 2020


riccibruno added a comment.

In D84678#2187747 <https://reviews.llvm.org/D84678#2187747>, @riccibruno wrote:

> In D84678#2184687 <https://reviews.llvm.org/D84678#2184687>, @Jac1494 wrote:
>
>> Hi @aaron.ballman ,
>> Address your review comments. 
>> Thank you for accepting this. I don't have commit access please commit this.
>> Thanks.
>
> As discussed with Aaron on IRC I can commit it for you. To do that I need a name and an email for the attribution.
> But first move the test to the already existing `test/Sema/void_arg.c` which already test this diagnostic.

Ah, it's a C++ test. Then put it into `test/SemaCXX/`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84678/new/

https://reviews.llvm.org/D84678



More information about the cfe-commits mailing list