[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev planned changes to this revision.
kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:112
+    if (!IndexRoot.empty()) {
+      llvm::DenseSet<SymbolID> ExcludeIDs;
+      for (const auto &Sym : *Result.Symbols)
----------------
hokein wrote:
> I think we could reuse the `FileShardedIndex` to do the filtering job, rather than implementing a new one.
Ah, this is interesting, I haven't seen `FileShardedIndex` before, let me take a look at its API, it looks like a convenient piece of infrastructure for implementing this!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84811/new/

https://reviews.llvm.org/D84811