[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

Amy Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 29 13:34:09 PDT 2020


akhuang added a comment.

In D84870#2182463 <https://reviews.llvm.org/D84870#2182463>, @dblaikie wrote:

> I think it'd be good to separate these two issues/patches.
>
> In part because I'm curious whether, even with a trivial ctor - if we did the retained types thing - would that be enough?

I think just the retained types thing wouldn't help in this case because the trivial ctor is not emitted? I tried it and the struct is still fwd declared. I could split out the retained types change, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84870/new/

https://reviews.llvm.org/D84870



More information about the cfe-commits mailing list