[PATCH] D84005: Introduce ns_error_domain attribute.

[Bruno Ricci via Phabricator via cfe-commits]

riccibruno added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5342
+    S.Diag(Loc, diag::err_nserrordomain_invalid_decl)
+        << 1 << DRE->getNameInfo().getName();
+    return;
----------------
Just send the declaration into the diagnostic. See the recent D84656 for the rationale.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5358
+    S.Diag(Loc, diag::err_nserrordomain_wrong_type)
+        << DRE->getNameInfo().getName();
+    return;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84005/new/

https://reviews.llvm.org/D84005