[clang] c26f237 - [analyzer] FuchsiaHandleChecker: Suppress a non-deterministic test failure.

Artem Dergachev via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 28 18:57:25 PDT 2020


Author: Artem Dergachev
Date: 2020-07-28T18:57:11-07:00
New Revision: c26f237cef1b33277f072c609c19192c5213f348

URL: https://github.com/llvm/llvm-project/commit/c26f237cef1b33277f072c609c19192c5213f348
DIFF: https://github.com/llvm/llvm-project/commit/c26f237cef1b33277f072c609c19192c5213f348.diff

LOG: [analyzer] FuchsiaHandleChecker: Suppress a non-deterministic test failure.

Noticed by Jon Roelofs in https://reviews.llvm.org/D73151#2180499

Added: 
    

Modified: 
    clang/test/Analysis/fuchsia_handle.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/Analysis/fuchsia_handle.cpp b/clang/test/Analysis/fuchsia_handle.cpp
index dade5261bd78..d104b13c77ab 100644
--- a/clang/test/Analysis/fuchsia_handle.cpp
+++ b/clang/test/Analysis/fuchsia_handle.cpp
@@ -77,7 +77,9 @@ void handleDieBeforeErrorSymbol01() {
 void handleDieBeforeErrorSymbol02() {
   zx_handle_t sa, sb;
   zx_status_t status = zx_channel_create(0, &sa, &sb);
-  // expected-note at -1 {{Handle allocated through 2nd parameter}}
+  // FIXME: There appears to be non-determinism in choosing
+  // which handle to report.
+  // expected-note-re at -3 {{Handle allocated through {{(2nd|3rd)}} parameter}}
   if (status == 0) { // expected-note {{Assuming 'status' is equal to 0}}
                      // expected-note at -1 {{Taking true branch}}
     return; // expected-warning {{Potential leak of handle}}


        


More information about the cfe-commits mailing list