[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

Vitaly Buka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 28 16:57:44 PDT 2020


vitalybuka added a comment.

LGTM as it fixes update_cc_test_checks.py



================
Comment at: llvm/utils/update_cc_test_checks.py:116-126
+def infer_dependent_args(args):
+  if args.clang is None:
+    if args.llvm_bin is None:
+      args.clang = 'clang'
+    else:
+      args.clang = os.path.join(args.llvm_bin, 'clang')
+  if args.opt is None:
----------------
I guess empty clang also make no sense, "not args.clang" is better here



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84511/new/

https://reviews.llvm.org/D84511



More information about the cfe-commits mailing list