[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

Tue Jul 28 06:44:36 PDT 2020

labath added a comment.

In D84554#2176041 <https://reviews.llvm.org/D84554#2176041>, @logan-5 wrote:

> In D84554#2175012 <https://reviews.llvm.org/D84554#2175012>, @labath wrote:
>
>> Could you elaborate on the lldb issue? I'd like to take a look at that...
>
> It looks like lldb/unittests/TestingSupport/CMakeLists.txt and lldb/unittests/TestingSupport/Symbol/CMakeLists.txt both both manually pull in the googletest/googlemock headers via `include_directories`. It also seems, although I'm not sure, like they don't themselves link to gtest, since simply removing those `include_directories` didn't work.

Thanks. I think I understand the problem now. Those libraries should be linking against gtest, but they don't do that because they could get away with not doing it. And they add include directories manually because they do not get that from linking against gtest. That means we have more things to fix => D84748 <https://reviews.llvm.org/D84748>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84554/new/

https://reviews.llvm.org/D84554