[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 28 02:26:07 PDT 2020


riccibruno added inline comments.


================
Comment at: clang/test/Sema/void-argument.cpp:1
+// RUN: not %clang_cc1 %s 2>&1 | FileCheck %s
+
----------------
Jac1494 wrote:
> riccibruno wrote:
> > These kinds of tests are typically done with a `-verify` test. See the other tests in `Sema/` for examples.
> we are testing here line number rather than diagnostic.
`-verify` implicitly checks line numbers. Even better: you don't have to hard-code the specific line numbers into the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84678/new/

https://reviews.llvm.org/D84678



More information about the cfe-commits mailing list