[PATCH] D83817: [clangd] Add option to use remote index as static index

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 27 05:11:12 PDT 2020


Ah, that's why... Thank you again and apologies for inconovinience!

On Mon, Jul 27, 2020 at 3:06 PM Hans Wennborg via Phabricator <
reviews at reviews.llvm.org> wrote:

> hans added inline comments.
>
>
> ================
> Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:702
>    }
> +  if (RemoteIndexAddress.empty() != ProjectPath.empty()) {
> +    llvm::errs() << "remote-index-address and project-path have to be "
> ----------------
> hokein wrote:
> > the new code section here should be guarded under `#ifdef
> CLANGD_ENABLE_REMOTE`
> I think it should be an #if since the macro is always defined (0 or 1).
> Doing that in 40d11a878044711708fb6738e4b78a4c9ac3de7b
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D83817/new/
>
> https://reviews.llvm.org/D83817
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200727/c8e06c56/attachment.html>


More information about the cfe-commits mailing list