[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added a comment.

I still wonder what made this statement live in my example. There must have been some non-trivial liveness analysis going on that caused a statement to be live; probably something to do with the C++ destructor elements.

In D82598#2172371 <https://reviews.llvm.org/D82598#2172371>, @Szelethus wrote:

> Wow, I never realized I accidentally landed that assert (D82122#2172360 <https://reviews.llvm.org/D82122#2172360>), but I guess its great to have that covered. Would you prefer to have that reverted as I'm looking to fix this for good?


It doesn't add any actual functionality so i think it makes sense to revert unless you have a quick fix.

Also if the assert is in fact true then i'd rather make a much stronger statement by banning statements from the Environment entirely, as in, like, at compile time by making it accept `Expr *` instead of `Stmt *`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82598/new/

https://reviews.llvm.org/D82598