[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

[Artem Dergachev via Phabricator via cfe-commits]

NoQ created this revision.
NoQ added reviewers: alexfh, gribozavr, dcoughlin, delcypher, yln, kubamracek, vsavchenko.
Herald added subscribers: martong, mgehre, Charusso, xazax.hun.

It's failing on macOS under AddressSanitizer for no obvious reason - i.e., no report is produced, just the code isn't working correctly. Might possibly be a bug in ASan but I want to silence an internal buildbot before a deeper investigation. I didn't try platforms other than macOS.

The failure can be reproduced somewhere around rG0b2a92224630f6e177d091b8391cfa943764aba5 <https://reviews.llvm.org/rG0b2a92224630f6e177d091b8391cfa943764aba5> by self-hosting. The unittest has to be compiled as ` -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_SANITIZER="Address"` in order to reproduce the issue (`RelWithDebInfo` works too, but not `Debug`).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D84453

Files:
  clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp


Index: clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
===================================================================
--- clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
+++ clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
@@ -21,6 +21,9 @@
   }
 };
 
+// FIXME: This test currently fails under ASan without any actual ASan report.
+// It's as if runCheckOnCode() is not invoked at all. Must be a bug.
+#if !defined(__has_feature) || !__has_feature(address_sanitizer)
 TEST(ClangTidyDiagnosticConsumer, SortsErrors) {
   std::vector<ClangTidyError> Errors;
   runCheckOnCode<TestCheck>("int a;", &Errors);
@@ -28,6 +31,7 @@
   EXPECT_EQ("type specifier", Errors[0].Message.Message);
   EXPECT_EQ("variable", Errors[1].Message.Message);
 }
+#endif
 
 } // namespace test
 } // namespace tidy


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84453.280207.patch
Type: text/x-patch
Size: 876 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200723/8f0291a7/attachment.bin>