[PATCH] D84375: [git-clang-format] Add --diffstat parameter

Roland via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 22 17:56:29 PDT 2020


roligugus added a project: clang-format.
roligugus marked an inline comment as done.
roligugus added inline comments.


================
Comment at: clang/tools/clang-format/git-clang-format:101
                  help='print a diff instead of applying the changes')
+  p.add_argument('--diffstat', action='store_true',
+                 help='print a diffstat instead of applying the changes')
----------------
As mentioned in the description, an alternative would be to add a `--stat` parameter and hand that to `print_diff(`). E.g. user would call it then with `git-clang-format --diff --stat`.

Would result in less code duplication of `print_diff()` vs `print_diffstat()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84375/new/

https://reviews.llvm.org/D84375





More information about the cfe-commits mailing list