[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 22 05:29:20 PDT 2020


kbobyrev added a comment.

In D84172#2166503 <https://reviews.llvm.org/D84172#2166503>, @ilya-golovenko wrote:

> In D84172#2166496 <https://reviews.llvm.org/D84172#2166496>, @kbobyrev wrote:
>
> > In D84172#2166448 <https://reviews.llvm.org/D84172#2166448>, @ilya-golovenko wrote:
> >
> > > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is my not-used-anymore account...
> > >  By the way, do you know is it possible to delete my unused account @walrus to avoid such confusions in future?
> >
> >
> > Not that I'm aware of :( I have way too many accounts myself, I'd be interested in that, too. I think not having your email associated with it anymore would be good.
> >
> > Hopefully, reviews move to GitHub at some point and this will not be necessary.
>
>
> I asked because according to policies all my commits should be attributed to Huawei (as this work is done here) and should be committed using my work email: ilya.golovenko at huawei.com, not with personal ilya.golovenko at gmail.com


Uh, I see, sorry for that. I'm afraid we can not rewrite the commit history to change the email for the one already submitted, but I think the commits are attributed to the primary email for your account, so simply changing it should do the trick.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84172/new/

https://reviews.llvm.org/D84172





More information about the cfe-commits mailing list