[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

[Arthur O'Dwyer via Phabricator via cfe-commits]

Quuxplusone added a comment.

For GTest and GMock specifically, it would be a good medium-term idea to try to upstream patches into those libraries. I did eventually have success upstreaming fixes for `-Wdeprecated` into GTest, for example: https://github.com/google/googletest/pull/2815
Disabling the warning in unittests for now still seems like a good short-term fix though.

(Although I'm a bit confused; I thought `-Wsuggest-override` was off-by-default? Is it part of `-Wall`, and do unittests add `-Wall` to their command line or something?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84244/new/

https://reviews.llvm.org/D84244