[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 20 05:54:45 PDT 2020


sammccall added a comment.
Herald added a subscriber: kbobyrev.

In D83508#2157954 <https://reviews.llvm.org/D83508#2157954>, @ArcsinX wrote:

> In D83508#2157859 <https://reviews.llvm.org/D83508#2157859>, @sammccall wrote:
>
> > Tried this out in D84012 <https://reviews.llvm.org/D84012>/D84009 <https://reviews.llvm.org/D84009>. Works pretty well, and I think the API is a useful and natural addition to TokenBuffer.
>
>
> For my test cases it works well, so I think this problem is fixed.
>  Should I abandon this revision?


I've landed those two patches, so I think so.
Thanks for raising this and working through it, I hope I didn't step on your toes to much here; this was a gap in TokenBuffer that I'd been hoping to have an excuse to fill at some point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83508/new/

https://reviews.llvm.org/D83508





More information about the cfe-commits mailing list