[PATCH] D84090: [clang-format] Add SpaceAroundBitFieldColon option

Krasimir Georgiev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 20 03:38:59 PDT 2020


krasimir added a comment.

@wanders, thank you for digging through code to get a feeling of the usage!

I agree with others to have an enum option. +1 to `None` over `Neither`.
I'd prefer `Before` / `After` instead of `Left` / `Right`; those seem more prevalent in names and values of existing options.
I'd slightly prefer leaving `After` / `Right` out; it seems it's not widely used and that would be one less case to maintain. However I'm OK with keeping it in for consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84090/new/

https://reviews.llvm.org/D84090





More information about the cfe-commits mailing list