[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

Evandro Menezes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 17 13:56:28 PDT 2020


evandro added a comment.

Just a couple of nits, but otherwise it LGTM.



================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:776
     }
-    return "";
+    llvm_unreachable("Unknown SEW.");
   }
----------------
I'd rather the first case be the `default` case and that it would call `llvm_unreachabe()` instead.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:796
     }
-    return "";
+    llvm_unreachable("Unknown LMUL.");
   }
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80802/new/

https://reviews.llvm.org/D80802





More information about the cfe-commits mailing list