[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 17 03:21:41 PDT 2020


sammccall added a comment.

Tried this out in D84012 <https://reviews.llvm.org/D84012>/D84009 <https://reviews.llvm.org/D84009>. Works pretty well, and I think the API is a useful and natural addition to TokenBuffer.
Maybe this is too much complexity though?

(Mostly here i'm worrying about the case when the user hits "select all" in their editor and we get a code action request or so - it seems wasteful to query the token buffer for every token in the file separately. But maybe this is in the noise in any case).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83508/new/

https://reviews.llvm.org/D83508





More information about the cfe-commits mailing list