[PATCH] D83901: [clang] Disable a few formatting options for test/

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

clang-format -n warnings before this change in clang/test/Analysis/*.cpp  (clang-format -n *.cpp |& grep warning | wc -l)

before = 6903 vs  after=6595, if it helps I'd say this looks good. Most a very brief review of changes seem to be mainly whitespace/extra lines and indentation  (44 in headers files vs 43)
(Note: There are 11 warnings after the first iteration, clang-format sometimes has to be run twice)

The real proof is how many of the unit tests can be clang-formatted and still pass, but I completely approve of this effort, if the test directories were formatted this would give us a massive test suite of lots of different examples of c++ code to validate any clang-format changes.

If having this in the clang-format file means users can use "Format on Save" options in their editors and not break tests then I think this is a good thing. As this will drive good behavior in all the other files rather than having to turn "Format on Save" off because we cannot maintain running tests.

My 2 cents worth.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83901/new/

https://reviews.llvm.org/D83901