[PATCH] D83648: [Driver] Fix integrated_as definition by setting it as a DriverOption

Pengxuan Zheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 12 18:27:10 PDT 2020


pzheng added a comment.

Actually, this patch won't change --help because it just reduced some duplication by extracting the common part (" the integrated assembler") of the help message into the "help" of "OptOutFFlag". Sorry for the confusion.

The real fix here is to restore "integrated_as" as a DriverOption. Without this, when we have -fintegrated-as on a link line, it will be passed to the linker and cause the linker to fail because it is not a valid linker flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83648/new/

https://reviews.llvm.org/D83648





More information about the cfe-commits mailing list