[PATCH] D82728: [clang] Add -Wsuggest-override

Logan Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 12 15:14:49 PDT 2020


logan-5 added a comment.

In D82728#2146067 <https://reviews.llvm.org/D82728#2146067>, @dblaikie wrote:

> Looks good - thanks for the patch and all the details! Might be worth turning on by default in the LLVM build (after all the cleanup)


Thanks a lot! I don't (think I) have commit access yada yada, so I'd really appreciate any help getting this committed.

I've already got some of the cleanup in the works (D83611 <https://reviews.llvm.org/D83611> and D83616 <https://reviews.llvm.org/D83616>), and was planning on taking care of the rest throughout the coming weekish. I'd be happy to turn this warning on in the LLVM build after that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82728/new/

https://reviews.llvm.org/D82728





More information about the cfe-commits mailing list