[PATCH] D82930: [HIP] Fix rocm detection

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 11 09:50:49 PDT 2020


yaxunl added a comment.

In D82930#2145914 <https://reviews.llvm.org/D82930#2145914>, @thakis wrote:

> This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt
>
> The output contains
>
>   5: clang: warning: argument unused during compilation: '--rocm-path=/Users/thakis/src/llvm-project/clang/test/Driver/Inputs/rocm' [-Wunused-command-line-argument]
>   
>
> which if true would explain the failure.
>
> That bot uses the GN build, but I verified that the test fails the same way in the CMake build.
>
> Please take a look, and if it takes a while to fix, please revert while you investigate.


should be fixed by 5d2c3e031a6861b3e95673d0e238c09938dd9c0d <https://reviews.llvm.org/rG5d2c3e031a6861b3e95673d0e238c09938dd9c0d>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82930/new/

https://reviews.llvm.org/D82930





More information about the cfe-commits mailing list