[PATCH] D82930: [HIP] Fix rocm detection

Sat Jul 11 09:27:54 PDT 2020

thakis added a comment.

This breaks check-clang on macOS: http://45.33.8.238/mac/17053/step_7.txt

The output contains

  5: clang: warning: argument unused during compilation: '--rocm-path=/Users/thakis/src/llvm-project/clang/test/Driver/Inputs/rocm' [-Wunused-command-line-argument]

which if true would explain the failure.

That bot uses the GN build, but I verified that the test fails the same way in the CMake build.

Please take a look, and if it takes a while to fix, please revert while you investigate.

================
Comment at: clang/test/Driver/Inputs/rocm/bin/.hipVersion:1
+# Auto-generated by cmake
+HIP_VERSION_MAJOR=3
----------------
Is this true? I don't see any cmake code generating this. Did I miss it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82930/new/

https://reviews.llvm.org/D82930