[PATCH] D82574: Merge TableGen files used for clang options

[Daniel Grumberg via Phabricator via cfe-commits]

dang marked an inline comment as done.
dang added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:3455
+  HelpText<"Specify target triple (e.g. i686-apple-darwin9)">,
+  MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::string">,
+  AlwaysEmit, Normalizer<"normalizeTriple">, DenormalizeString;
----------------
herhut wrote:
> There is some explicit normalization missing here. In CC1Options.td this is
> 
> ```
> def triple : Separate<["-"], "triple">,
>   HelpText<"Specify target triple (e.g. i686-apple-darwin9)">,
>   MarshallingInfoString<"TargetOpts->Triple", "llvm::Triple::normalize(llvm::sys::getDefaultTargetTriple())", "std::string">,
>   AlwaysEmit, Normalizer<"normalizeTriple">, DenormalizeString;
> ```
> 
> It seems the normalizer does not apply to the defaults and we now see a failure in `clang/unittests/Frontend/CompilerInvocationTest.cpp` for powerpc targets.
Of course, I must have lost it at some point. Can you link me to the failure for reference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82574/new/

https://reviews.llvm.org/D82574