[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 10 04:17:11 PDT 2020


Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.

I'd prefer if you moved `f_leak_2` to `stream-notes.c`. Otherwise, LGTM.



================
Comment at: clang/test/Analysis/stream.c:147-150
+  FILE *p1 = fopen("foo1.c", "r");
+  if (!p1)
+    return;
+  FILE *p2 = fopen("foo2.c", "r");
----------------
I'd prefer to see notes from D81407 here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82845/new/

https://reviews.llvm.org/D82845





More information about the cfe-commits mailing list