[PATCH] D82436: [clangd] Implement textDocument/foldingRange

Thu Jul 9 14:14:30 PDT 2020

kbobyrev marked an inline comment as done.
kbobyrev added a comment.

In D82436#2141953 <https://reviews.llvm.org/D82436#2141953>, @sammccall wrote:

> Tests :-)

I was hoping glorious DocumentSymbols super tested API would shield me from that :P Didn't think of reasonable testing strategy but fair enough, will do!

================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:300
+opt<bool> FoldingRanges{
+    "folding-rangees",
+    cat(Features),
----------------
sammccall wrote:
> rangees -> ranges
My broken keyboard puts multiple symbols all over the place :( Catching them all is hard, sorry, the other patch also had a couple of those.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82436/new/

https://reviews.llvm.org/D82436