[PATCH] D83349: [OpenMP][NFC] Remove unused and untested code from the device runtime

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 7 14:53:25 PDT 2020


jdoerfert created this revision.
jdoerfert added reviewers: hfinkel, jhuber6, fghanim, JonChesterfield, grokos, AndreyChurbanov, ye-luo, tianshilei1992, ggeorgakoudis, Hahnfeld, ABataev, hbae, ronlieb, gregrodgers.
Herald added subscribers: cfe-commits, aaron.ballman, sstefan1, jfb, guansong, bollu, yaxunl, jvesely.
Herald added projects: clang, OpenMP.

We carried a lot of unused and untested code in the device runtime.
Among other reasons, we are planning major rewrites for which reduced
size is going to help a lot.

The number of code lines reduced by 14%!

Before:
-------

Language                     files          blank        comment           code
-------------------------------------------------------------------------------

CUDA                            13            489            841           2454
C/C++ Header                    14            322            493           1377
C                               12            117            124            559
CMake                            4             64             64            262

C++                              1              6              6             39
-------------------------------------------------------------------------------

SUM:                            44            998           1528           4691
-------------------------------------------------------------------------------

After:
------

Language                     files          blank        comment           code
-------------------------------------------------------------------------------

CUDA                            13            366            733           1879
C/C++ Header                    14            317            484           1293
C                               12            117            124            559
CMake                            4             64             64            262

C++                              1              6              6             39
-------------------------------------------------------------------------------

SUM:                            44            870           1411           4032
-------------------------------------------------------------------------------


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83349

Files:
  clang/test/OpenMP/nvptx_target_simd_codegen.cpp
  openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
  openmp/libomptarget/deviceRTLs/common/omptarget.h
  openmp/libomptarget/deviceRTLs/common/src/data_sharing.cu
  openmp/libomptarget/deviceRTLs/common/src/libcall.cu
  openmp/libomptarget/deviceRTLs/common/src/loop.cu
  openmp/libomptarget/deviceRTLs/common/src/omptarget.cu
  openmp/libomptarget/deviceRTLs/common/src/parallel.cu
  openmp/libomptarget/deviceRTLs/common/src/reduction.cu
  openmp/libomptarget/deviceRTLs/common/src/support.cu
  openmp/libomptarget/deviceRTLs/common/src/sync.cu
  openmp/libomptarget/deviceRTLs/common/support.h
  openmp/libomptarget/deviceRTLs/interface.h
  openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83349.276225.patch
Type: text/x-patch
Size: 50590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200707/69bd2eff/attachment-0001.bin>


More information about the cfe-commits mailing list