[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

Hubert Tong via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 7 07:29:33 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:523
+  if (isa<CXXRecordDecl>(RT->getDecl())) {
+    if (!(AllowNoUniqueAddr && FD->hasAttr<NoUniqueAddressAttr>()))
+      return false;
----------------
Minor nit:
The nested `if` could be merged with the outer one:
```
  if (isa<CXXRecordDecl>(RT->getDecl()) &&
      !(AllowNoUniqueAddr && FD->hasAttr<NoUniqueAddressAttr>()))
    return false;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81583/new/

https://reviews.llvm.org/D81583





More information about the cfe-commits mailing list