[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 7 02:59:40 PDT 2020


sammccall added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:12944
+      Fn->getBeginLoc(), RParenLoc, SubExprs,
+      ReturnType.isNull()
+          ? ReturnType
----------------
here we're splitting the type (e.g. int&&) into a type + VK, and passing both to createrecoveryexpr.

Why not do that on recoveryexpr side? e.g. if we request a recoveryexpr of type int&, return an LValue recoveryexpr of type int?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83201/new/

https://reviews.llvm.org/D83201





More information about the cfe-commits mailing list