[PATCH] D83233: [clangd] Enable reading config from files by default.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 7 00:31:03 PDT 2020


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:436
+        "Project config is from a .clangd file in the project directory.\n"
+        "User config is from clangd/config.yaml in the following directories:\n"
+        "\tWindows: %USERPROFILE%\\AppData\\Local\n"
----------------
nit: maybe worth mentioning that the user config has higher privilege.


================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:440
+        "\tOthers: $XDG_CONFIG_HOME, usually ~/.config"),
+    init(true),
+};
----------------
nit: I'd keep this flag off in this patch, and flip it in a new patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83233/new/

https://reviews.llvm.org/D83233





More information about the cfe-commits mailing list