[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

Akira Hatanaka via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 6 18:51:57 PDT 2020


ahatanak added a comment.

This looks good to me.



================
Comment at: clang/lib/Sema/SemaChecking.cpp:11825
 
+  Expr *TrueExpr = E->getTrueExpr();
+  if (isa<BinaryConditionalOperator>(E))
----------------
Can you use `BinaryConditionalOperator::getCommon` here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81751/new/

https://reviews.llvm.org/D81751





More information about the cfe-commits mailing list