[PATCH] D82930: [HIP] Fix rocm detection

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167
+    llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> VersionFile =
+        FS.getBufferForFile(BinPath + "/.hipVersion");
+    if (!VersionFile)
----------------
yaxunl wrote:
> arsenm wrote:
> > arsenm wrote:
> > > yaxunl wrote:
> > > > arsenm wrote:
> > > > > I don't think the detection should fail if this is missing
> > > > why? this file is unique to HIP installation. If it is missing, the installation is broken.
> > > Because I should be able to use this without a complete hip installation. Without a specified version, it should assume the most modern layout. This will for example break pointing --rocm-path at the device library build directory for library tests
> > I also don't see what value checking the version really provides; it may be informative to print it, but I don't think it's useful to derive information from it
> what is the directory structure of your most modern layout?
/opt/rocm/amdgcn/bitcode/foo.bc

The plan is to remove this and rely on symlinks in the resource directory though


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82930/new/

https://reviews.llvm.org/D82930