[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

Eduardo Caldas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 23:15:07 PDT 2020


eduucaldas accepted this revision.
eduucaldas added inline comments.


================
Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:501
   WalkUpFromStmt IntegerLiteral(1)
-WalkUpFromBinaryOperator BinaryOperator(+)
-  WalkUpFromExpr BinaryOperator(+)
-    WalkUpFromStmt BinaryOperator(+)
+WalkUpFromUnaryOperator UnaryOperator(-)
+  WalkUpFromExpr UnaryOperator(-)
----------------
A question came to mind: " Does WalkUpFromUnaryMinus walk up to WalkUpFromUnaryOperator? " Perhaps that could be included in a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82875/new/

https://reviews.llvm.org/D82875





More information about the cfe-commits mailing list