[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

liu hui via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 22:11:06 PDT 2020


lh123 added a comment.

In D82548#2124546 <https://reviews.llvm.org/D82548#2124546>, @MaskRay wrote:

> Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script:
>
>   arcfilter () {
>           arc amend
>           git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
>   }
>   
>
> `Reviewed By: ` is considered important by some people. Please keep the tag. (`--date=now` is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))
>
> `https://reviews.llvm.org/D80978` contains a git pre-push hook to automate this.


Thanks, should I revert it and recommit it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82548/new/

https://reviews.llvm.org/D82548





More information about the cfe-commits mailing list