[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

Tue Jun 30 08:06:41 PDT 2020

baloghadamsoftware added a comment.

In D79431#2020951 <https://reviews.llvm.org/D79431#2020951>, @Szelethus wrote:

> Sure, this is an improvement because we display more information, but I'd argue that it isn't really a more readable warning message :) How about
>
> <argno>th argument to the call to <function name>
>
> - cannot be represented with a character
> - is a null pointer
> - ... , which violates the function's preconditions.
>
>   WDYT?

+1 Warning messages should be as clear as possible. Although our users are programmers, they do not necessarily understand a message "Range constraint not satisfied.". Maybe the error messages could be stored together with the function summaries.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79431/new/

https://reviews.llvm.org/D79431