[PATCH] D82677: [Clang] Handle AIX Include management in the driver

David Tenty via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 07:34:15 PDT 2020


daltenty added inline comments.


================
Comment at: clang/test/Driver/aix-toolchain-include.cpp:1
+// Tests that aix toolchain adds system includes to the search path
+
----------------
nit: aix->AIX
nit: period at end of comment.


================
Comment at: clang/test/Driver/aix-toolchain-include.cpp:5
+// RUN: %clangxx -### -no-canonical-prefixes %s 2>&1 \
+// RUN:		-target powerpc-ibm-aix \
+// RUN:		-resource-dir=%S/Inputs/resource_dir \
----------------
I think we should test the 64-bit target as well.


================
Comment at: clang/test/Driver/aix-toolchain-include.cpp:15
+// RUN: %clangxx -### -no-canonical-prefixes %s 2>&1 \
+// RUN:		-target powerpc-ibm-aix \
+// RUN:		-resource-dir=%S/Inputs/resource_dir \
----------------
Same comment as above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82677/new/

https://reviews.llvm.org/D82677





More information about the cfe-commits mailing list