[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 06:28:35 PDT 2020


balazske added a comment.

It looks like that the dependency manipulation and computation functions, and the checker and option add functions can be member of `CheckerRegistryData`. It would be a bit more simple (no `Data.` call), and these belong naturally to there.



================
Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h:155
   /// Constructs a CheckerManager without requiring an AST. No checker
-  /// registration will take place. Only useful for retrieving the
-  /// CheckerRegistry and print for help flags where the AST is unavalaible.
+  /// registration will take placer. Only useful when one needs to print the
+  /// help flags through CheckerRegistryData, and the AST is unavalaible.
----------------
placer -> place


================
Comment at: clang/include/clang/StaticAnalyzer/Core/CheckerRegistryData.h:199
+  PackageInfoList Packages;
+  /// Used for couting how many checkers belong to a certain package in the
+  /// \c Checkers field. For convenience purposes.
----------------
couting -> counting


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82585/new/

https://reviews.llvm.org/D82585





More information about the cfe-commits mailing list