[PATCH] D82781: [OpenCL] Fix missing address space deduction in template variables

Ole Strohm via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 02:08:16 PDT 2020


olestrohm added a comment.

Essentially, in each pass the type for the variable starts off being extract from the SourceTypeInfo, but since the address space isn't specified, this type is then missing an address space.
Adding the address space deduction then reintroduces the address space to the type.

This is then done at least three times (pre-specialization, in the middle of specialization and when completing specialization), but since this is a template it may not be possible to correctly
deduce the type earlier in case the template type introduces an address space in template specialization?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82781/new/

https://reviews.llvm.org/D82781





More information about the cfe-commits mailing list