[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 29 04:17:19 PDT 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM, though I think this should be landed in two commits (one for the headers, one for the tests).



================
Comment at: clang-tools-extra/test/clang-tidy/checkers/google-module.cpp:4
+// CHECK-DAG: {{- key: *google-readability-braces-around-statements.ShortStatementLines[[:space:]] value: *'1'}}
+// CHECK-DAG: {{- key: *google-readability-function-size.StatementThreshold[[:space:]] value: *'800'}}
+// CHECK-DAG: {{- key: *google-readability-namespace-comments.ShortNamespaceLines[[:space:]] value: *'10'}}
----------------
I feel like these testing changes, while NFC, should be landed in a separate patch as they don't have anything to do with the header file changes, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82661/new/

https://reviews.llvm.org/D82661





More information about the cfe-commits mailing list