[PATCH] D81169: [clangd] Improve hover on arguments to function call

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 26 08:44:41 PDT 2020


adamcz updated this revision to Diff 273742.
adamcz marked 2 inline comments as done.
adamcz added a comment.

Formatting changed to spell out [const] reference and hide type unless conversion happens.
Defining what the "correct" behavior is on various cases is very difficult.
This is my best shot at incorporating previous requests and comments.

Also addressed more review comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81169/new/

https://reviews.llvm.org/D81169

Files:
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/Hover.h
  clang-tools-extra/clangd/unittests/HoverTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81169.273742.patch
Type: text/x-patch
Size: 17003 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200626/5bedb34a/attachment-0001.bin>


More information about the cfe-commits mailing list