[PATCH] D82623: [sve][acle] Enable feature macros for SVE ACLE extensions.

[Sander de Smalen via Phabricator via cfe-commits]

sdesmalen added a comment.

Hi @fpetrogalli , I see the patch is still missing a few tests to `clang/test/Preprocessor/aarch64-target-features.c`.

Not specifically to be done in this patch, but we'll also needs changes to make sure that the bfloat macros are set for armv8.6 (e.g. `-march=armv8.6-a+sve*`).
See `DecodeAArch64Features` in `clang/lib/Driver/ToolChains/Arch/AArch64`.



================
Comment at: clang/lib/Basic/Targets/AArch64.cpp:315
+    Builder.defineMacro("__ARM_FEATURE_SVE_BF16", "1");
+    Builder.defineMacro("__ARM_FEATURE_BF16_SCALAR_ARITHMETIC", "1");
+  }
----------------
Should `__ARM_FEATURE_BF16_SCALAR_ARITHMETIC` not be defined under `HasBFloat16`?


================
Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_whilewr-bfloat.c:14
-
-// Test expected ambiguous call error for overloaded form when +bf16 is missing
-// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -DSVE_OVERLOADED_FORMS -triple aarch64-none-linux-gnu -target-feature +sve2 -target-feature +bf16 -fallow-half-arguments-and-returns -fsyntax-only -verify=overload-bf16 -verify-ignore-unexpected=note %s
----------------
unrelated change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82623/new/

https://reviews.llvm.org/D82623