[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 26 02:41:09 PDT 2020


xazax.hun added a comment.

In D82598#2115656 <https://reviews.llvm.org/D82598#2115656>, @NoQ wrote:

> > We could just kill all subexpr at the end of the full expression
>
> I suspect that it would be pretty bad if you, say, kill the condition of the `if`-statement before picking the branch. Or kill the initializer in the `DeclStmt` before putting it into the variable (same for `CXXCtorInitializer` which isn't even a `Stmt`!).


I would argue that the end of the full expression is AFTER the `if` was evaluated in this case. But I do see what you mean, thanks :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82598/new/

https://reviews.llvm.org/D82598





More information about the cfe-commits mailing list