[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

liu hui via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 08:36:53 PDT 2020


lh123 marked an inline comment as done.
lh123 added inline comments.


================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058
       Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
-      Builder.AddPlaceholderChunk("qualifier");
-      Builder.AddTextChunk("::");
----------------
kadircet wrote:
> unfortunately the reasoning above doesn't apply here, as a using declaration *must* have a nested-name-specifier. e.g. `using X;` is not allowed. so please revert this (and following on `using typename` it requires a nested-name-specifier too)
Yes, you are right. but I think complete `using` as `using qualifier::name` is not useful when user want input something like `using A = B`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82373/new/

https://reviews.llvm.org/D82373





More information about the cfe-commits mailing list