[PATCH] D82360: Add StringLiteral to SyntaxTree

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 03:44:56 PDT 2020


gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.

LGTM with improved testing.



================
Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1237
+  "a\n";
+  L"a";
+}
----------------
Could you add some non-ASCII characters to tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82360/new/

https://reviews.llvm.org/D82360





More information about the cfe-commits mailing list