[PATCH] D82099: [AST][RecoveryAST] Populate error-bit from Type to Expr.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 24 00:29:59 PDT 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/AST/DependenceFlags.h:123
+          translate(D, TypeDependence::Dependent, Dependent) |
+          translate(D, TypeDependence::Error, Error) |
+          translate(D, TypeDependence::VariablyModified, VariablyModified)) {}
----------------
oops! seems like we should be able to observe this directly in an AST dump test too, which should be failing to mark some nodes as error-dependent.
(Not sure if there's a simpler example than your crashing testcase though)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82099/new/

https://reviews.llvm.org/D82099





More information about the cfe-commits mailing list