[clang] 5804a8b - [WebAssebmly] Fully disable 'protected' visibility

Sam Clegg via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 23 17:50:22 PDT 2020


Author: Sam Clegg
Date: 2020-06-23T17:50:05-07:00
New Revision: 5804a8b1228ba890d48f4085a3a192ef83c73e00

URL: https://github.com/llvm/llvm-project/commit/5804a8b1228ba890d48f4085a3a192ef83c73e00
DIFF: https://github.com/llvm/llvm-project/commit/5804a8b1228ba890d48f4085a3a192ef83c73e00.diff

LOG: [WebAssebmly] Fully disable 'protected' visibility

Emscripten doesn't use protected visibility either.

Differential Revision: https://reviews.llvm.org/D82346

Added: 
    

Modified: 
    clang/lib/Basic/Targets/WebAssembly.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/Basic/Targets/WebAssembly.h b/clang/lib/Basic/Targets/WebAssembly.h
index e09e21d90802..77a2fe9ae117 100644
--- a/clang/lib/Basic/Targets/WebAssembly.h
+++ b/clang/lib/Basic/Targets/WebAssembly.h
@@ -133,11 +133,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public TargetInfo {
 
   bool hasExtIntType() const override { return true; }
 
-  bool hasProtectedVisibility() const override {
-    // TODO: For now, continue to advertise "protected" support for
-    // Emscripten targets.
-    return getTriple().isOSEmscripten();
-  }
+  bool hasProtectedVisibility() const override { return false; }
 };
 
 class LLVM_LIBRARY_VISIBILITY WebAssembly32TargetInfo


        


More information about the cfe-commits mailing list