[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

Mitch Phillips via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 22 17:12:51 PDT 2020


hctim added a comment.

In D82249#2105036 <https://reviews.llvm.org/D82249#2105036>, @arsenm wrote:

> Is the fallback not working correctly in this case for some reason?


I'm fairly sure that G_GLOBAL_VALUE used to fallback onto SelectionDAGISel, and that was changed in D78465 <https://reviews.llvm.org/D78465>. Because we only implemented the custom `adrp+movk` lowering in SelectionDAGISel, making that instruction sequence no longer fallback, so we don't get our proper lowering for HWASan globals.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82249/new/

https://reviews.llvm.org/D82249





More information about the cfe-commits mailing list