[PATCH] D82259: Deprecate error prone temporary directory APIs

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 22 09:39:58 PDT 2020


aprantl added inline comments.


================
Comment at: lib/Driver/ToolChains/Clang.cpp:3176
+  if (llvm::sys::path::cache_directory(Result)) {
+    llvm::sys::path::append(Result, "clang");
+    llvm::sys::path::append(Result, "ModuleCache");
----------------
I would prefer to separate this out into its own patch. This is going to silently(!) break all sorts of scripts — for example many buildbots have a "clean module cache" action that searches for a directory with this name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82259/new/

https://reviews.llvm.org/D82259





More information about the cfe-commits mailing list