[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

[Ferran Pallarès Roca via Phabricator via cfe-commits]

fpallares added a comment.

Hi @HsiangKai, thanks for the patch. So far everything looks good aside from a couple of minor nits.



================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1638
+
+  if (getLexer().getKind() == AsmToken::EndOfStatement) {
+    Operands.push_back(RISCVOperand::createVType(
----------------
While the spec currently states that specifying the `vta` and `mta` in `vsetvli` is not mandatory, it also states that not specifying them should be deprecated. Therefore, I'm not sure we should allow specifying the `vta` without specifying the `mta`.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVInstPrinter.cpp:172
+  bool MaskedoffAgnostic = Imm & 0x80;
+  if (TailAgnostic || MaskedoffAgnostic) {
+    if (TailAgnostic)
----------------
Given that the use of `vsetvli` without these flags should be deprecated, I'd recommend printing them always, even if it more verbose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80802/new/

https://reviews.llvm.org/D80802