[PATCH] D82279: Handle invalid types in the nullPointerConstant AST matcher

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jun 21 14:18:25 PDT 2020


steveire added inline comments.


================
Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2618
+  )";
+  EXPECT_TRUE(matches(kTest, expr(nullPointerConstant())));
 }
----------------
While this test in ASTMatchers might continue to make sense, shouldn't there be a test in `clang/unittests/AST` for this API? `isNullPointerConstant` seems to be complicated. Does it have a unit test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82279/new/

https://reviews.llvm.org/D82279





More information about the cfe-commits mailing list